Skip to content

Replace Wallet features section with quantum secure encrypted money s… - #47

Merged
dewabisma merged 2 commits into
Quantus-Network:mainfrom
sejhere:copy/wallet-qsem-section
Sep 8, 2026
Merged

Replace Wallet features section with quantum secure encrypted money s…#47
dewabisma merged 2 commits into
Quantus-Network:mainfrom
sejhere:copy/wallet-qsem-section

Conversation

@sejhere

@sejhere sejhere commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Copy is drafted and needs Jangle's review. The "Encrypted"
block is the one to read closely: it makes a privacy claim
that no longer has a supporting card behind it.

…ection

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dewabisma
dewabisma requested a review from n13 September 8, 2026 13:14

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: REQUEST_CHANGES

Blocking finding:

  • website/src/i18n/en-US.json:440 — The new copy says that balances and transfers are encrypted rather than broadcast and that holdings and counterparties remain private. That is broader than the protocol described by this repository's current whitepaper: transparent-address balances and transfers are visible on-chain (website/src/contents/whitepapers/en-US/v0.4.0.mdx:263); wormhole deposit addresses also retain a visible balance; and encrypted exits expose amounts and exit addresses, with privacy explicitly described as probabilistic (:275-277). As written, the wallet page promises privacy the protocol does not provide, and the same promise is propagated to all localized copies. Please distinguish the transparent and encrypted transaction modes, accurately state what encrypted transfers conceal and what remains public, and then synchronize the corrected wording across the nine locales.

Validation:

  • git diff --check: passed.
  • All nine changed locale JSON files parse, have complete wallet.money key parity, and generated wallet pages contain the localized content.
  • PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfile: passed.
  • npx --yes bun run build: passed (1,444 pages, including every localized wallet route). The build's missing-translation and compression warnings are in unchanged paths.
  • Focused Prettier check passed for the changed Astro files and eight locale files; zh-CN.json reports only pre-existing formatting outside this diff. check:seo-meta reports only unchanged launch.meta entries.

The component replacement, asset references, locale wiring, and responsive structure otherwise look sound, but the public-facing privacy claim needs correction before merge.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sejhere

sejhere commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Fixed in db3c393. The block now distinguishes transparent and
encrypted modes, states that an encrypted send breaks the
sender-receiver link with the proof generated on device, and
says plainly that amounts remain visible and the privacy is
probabilistic rather than absolute. Drawn from v0.4.0 lines
275 and 277.

@sejhere
sejhere requested a review from n13 September 8, 2026 14:20
@dewabisma
dewabisma requested review from n13 and removed request for n13 September 8, 2026 14:33
n13
n13 previously requested changes Sep 8, 2026

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: REQUEST_CHANGES — the corrected encrypted-mode copy is now accurate, but the same overbroad privacy claim remains in the Chinese page metadata.

Blocking finding:

  • website/src/i18n/zh-CN.json:416 — The new Chinese meta description still says 余额与转账全程加密 ("balances and transfers are encrypted throughout"). This ships in the page description plus Open Graph and Twitter metadata, contradicts the corrected body at line 440, and is broader than the whitepaper: transparent and wormhole-address balances are visible, encrypted transfers leave amounts visible, and only break the sender-receiver link (website/src/contents/whitepapers/en-US/v0.4.0.mdx:263,275-277). Please remove or replace this extra clause so the Chinese metadata matches the English copy and the protocol.

Validation:

  • Reviewed exact base 9f71318783b1cfe9c2a6fe6592ed24afbe1bac60 through head db3c39361bccbae3f7c0d7d55a063c294a7abfc7, including the full diff and follow-up commit.
  • git diff --check: passed; removed section/assets have no stale source references.
  • All nine changed locale JSON files parse and have matching wallet.money key sets.
  • PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfile: passed.
  • npx --yes bun run build: passed (1,444 pages, including all localized wallet routes).
  • Focused Prettier check passed for the changed Astro files and eight locale files; zh-CN.json reports only pre-existing formatting at lines 649+ outside this diff. check:seo-meta reports only unchanged launch.meta entries.

The follow-up correctly fixes all nine wallet.money.blocks.encrypted.body strings, and the component replacement, locale wiring, asset usage, and responsive structure otherwise look sound.

@dewabisma
dewabisma merged commit 45bde26 into Quantus-Network:main Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants